Initial work for enabling React Native Intellisense #9
Conversation
| /** | ||
| * Helper function to asynchronously copy a file | ||
| */ | ||
| public static copyFile(from: string, to: string, encoding?: string): Q.Promise<any> { |
There was a problem hiding this comment.
Is it possible to open the files in binary format so we won't need to pass the encoding parameter?
There was a problem hiding this comment.
It's an optional parameter and we don't actually use it. I still think it is useful even if we currently aren't using it. If you feel strongly about it, I would consider removing it.
## Changes - Made TsConfigHelper promisey - Fixed promises in TsdHelper - Simplified how we work with the listing of typings
| var fileSystem:FileSystem = new FileSystem(); | ||
| var reactTypeDefsPath = path.resolve(__dirname, "..", "..", "reactTypings.json"); | ||
|
|
||
| if (fileSystem.existsSync(reactTypeDefsPath)) { |
There was a problem hiding this comment.
Why do we need to check if this file exists? Dont we want the extesion to throw an error if its not there?
There was a problem hiding this comment.
Do we want to throw an error?
There was a problem hiding this comment.
I'm assuming that this file will be shipped with the extension. The only reason why it might not be there might be because the installation of the extension broke somehow. I'm guessing that we want to show an error, and possibly suggest the person to re-install the extension (so this file will appear on the proper place).
|
Minor comments, otherwise LGTM! |
| */ | ||
| public makeDirectoryRecursive(dirPath: string): void { | ||
| let parentPath = path.dirname(dirPath); | ||
| if (!this.existsSync(parentPath)) { |
There was a problem hiding this comment.
In general, we should try to make anything that runs inside the extension process Async because we share that process with other extensions.
# Conflicts: # src/utils/packageJsonWatcher.ts
| // Add typings for React and React Native | ||
| var reactTypeDefsPath = path.resolve(__dirname, "..", "reactTypings.json"); | ||
| var typeDefsToInstall:string[] = require(reactTypeDefsPath); | ||
| TsdHelper.installTypings(TsdHelper.getOrCreateTypingsTargetPath(vscode.workspace.rootPath),typeDefsToInstall).done(); |
# Conflicts: # src/rn-extension.ts
## Changes - Removed TsdHelper - Added copyRecursive to fileSystem - Added environment variable check to lighting up intellisense
| @@ -0,0 +1,14 @@ | |||
| [ | |||
| "react/react.d.ts", | |||
There was a problem hiding this comment.
why do we need this json file?
There was a problem hiding this comment.
We don't I'll remove it.
|
Looks good. :) |
Initial work for enabling React Native Intellisense
Summary
Enabling Salsa intellisense for React Native. This is done by configuring the workspace as outlined here: https://github.com/Microsoft/vscode-docs/blob/vnext/release-notes/latest.md
Additionally we configure the tsconfig.json file which is not mentioned in the above, but still needed.
Changes