Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force the pytest root dir to always be the workspace root. #7803

Conversation

ericsnowcurrently
Copy link
Member

(for #6548)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [ ] Appropriate comments and documentation strings in the code
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Oct 7, 2019

Codecov Report

Merging #7803 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7803      +/-   ##
==========================================
+ Coverage   59.15%   59.16%   +<.01%     
==========================================
  Files         498      498              
  Lines       22254    22256       +2     
  Branches     3578     3578              
==========================================
+ Hits        13164    13167       +3     
+ Misses       8266     8265       -1     
  Partials      824      824
Impacted Files Coverage Δ
src/client/testing/pytest/runner.ts 17.64% <0%> (-0.36%) ⬇️
...client/testing/pytest/services/discoveryService.ts 88.23% <100%> (+0.35%) ⬆️
src/client/common/utils/platform.ts 88.23% <0%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 987b4de...527a4b0. Read the comment docs.

@ericsnowcurrently ericsnowcurrently merged commit 9fe2a76 into microsoft:master Oct 8, 2019
@ericsnowcurrently ericsnowcurrently deleted the fix-6548-pytest-ini-root-dir branch October 8, 2019 20:18
@lock lock bot locked as resolved and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants