Append --pre to black installation command when pipenv is used #5393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so it can be resolved correctly by pipenv
update news
|
|
erinxocon
changed the title
DonJayamanne
approved these changes
Apr 23, 2019
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Black is currently in pre-prelease on pypi, hence pipenv fails to install it when vscode-python invokes it. This fixes that with a special case for black that applies the
--preflag when it is installed. This will allow all pre-releases in a pipfile so if a user doesn't want to have pre-release packages and still wants to use black, they should install black globally and make sure it's in their path. Then you can set the proper settings in vscode to tell it where the black executable is located.For #5171
Has sufficient logging.Has telemetry for enhancements.Unit tests & system/integration tests are added/updatedTest plan is updated as appropriatepackage-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)The wiki is updated with any design decisions/details.