Wait 0.5 second for shell integration event, otherwise fall back to sendtext. #24248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonykim1
added
bug
karthiknadig
approved these changes
Oct 4, 2024
karthiknadig
pushed a commit
that referenced
this pull request
Oct 7, 2024
…endtext. (#24248) For some reason, it seems like shell integration may take awhile to get activated: #24239 Performance issue seemed to indicate exactly 3 second coming from the https://github.com/microsoft/vscode-python/pull/24078/files#diff-5290f3097d5f92e3495c8abfbe095dff83c3f8de3dcac08ab2d0304f71bb412fR93, so lets try reducing this to 0.5 second and let user fall back to sendText. We may need further investigate why onDidChangeTerminalShellIntegration may be taking awhile.
karthiknadig
pushed a commit
that referenced
this pull request
Oct 7, 2024
…endtext. (#24248) For some reason, it seems like shell integration may take awhile to get activated: #24239 Performance issue seemed to indicate exactly 3 second coming from the https://github.com/microsoft/vscode-python/pull/24078/files#diff-5290f3097d5f92e3495c8abfbe095dff83c3f8de3dcac08ab2d0304f71bb412fR93, so lets try reducing this to 0.5 second and let user fall back to sendText. We may need further investigate why onDidChangeTerminalShellIntegration may be taking awhile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, it seems like shell integration may take awhile to get activated: #24239
Performance issue seemed to indicate exactly 3 second coming from the https://github.com/microsoft/vscode-python/pull/24078/files#diff-5290f3097d5f92e3495c8abfbe095dff83c3f8de3dcac08ab2d0304f71bb412fR93, so lets try reducing this to 0.5 second and let user fall back to sendText. We may need further investigate why onDidChangeTerminalShellIntegration may be taking awhile.