Finalizing design of proposed API for python environments #19841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrtikr
force-pushed
the
proposedenvapis
branch
4 times, most recently
from
dcffa32
to
b29e964
Compare
jrieken
reviewed
Sep 23, 2022
jrieken
reviewed
Sep 23, 2022
src/client/proposedApiTypes.ts
Outdated
| * Carries environments found by the extension at the time of fetching the property. Note a refresh might be | ||
| * going on so this may not be the complete list. | ||
| */ | ||
| readonly environments: Environment[]; |
There was a problem hiding this comment.
Should this be called all? E.g today the fully qualified name is pythonExtApi.environment.environments which is a bit funny. IMO environment.all or something similar reads more fluent
There was a problem hiding this comment.
also strongly suggesting to mark this a readonly-array via readonly Environment[] so that extensions don't start to the remove/add elements. Guard the implementation via Object.freeze
jrieken
reviewed
Sep 23, 2022
jrieken
reviewed
Sep 23, 2022
jrieken
reviewed
Sep 23, 2022
|
I'm quite happy with how this has turned out, thanks for all the help! We eventually plan to publish this as a npm types package so it's easier for other extensions to access this. |
karrtikr
force-pushed
the
proposedenvapis
branch
from
85fcc73
to
b5769ff
Compare
karrtikr
force-pushed
the
proposedenvapis
branch
from
42356e3
to
7303339
Compare
karthiknadig
approved these changes
Sep 26, 2022
eleanorjboyd
pushed a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Oct 4, 2022
…19841) Closes microsoft#19101 closes microsoft#18973 Co-authored-by: Karthik Nadig <[email protected]>
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…vscode-python#19841) Closes microsoft/vscode-python#19101 closes #18973 Co-authored-by: Karthik Nadig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19101 closes #18973