Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix any type issue that caused experiment bug to be missed #19740

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

debonte
Copy link

@debonte debonte commented Aug 26, 2022

packageJSON is of type any and everything went downhill after that. This is my first time getting bitten by something like this. Should I be using TypeScript's strict mode?

#19737

@debonte debonte added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. skip tests Updates to tests unnecessary labels Aug 26, 2022
@karthiknadig
Copy link
Member

Yes. Typescript strict mode should help with these.

@debonte debonte merged commit 5d8a3cb into microsoft:main Aug 26, 2022
@debonte debonte deleted the fixAny branch August 26, 2022 06:18
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants