Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent auto-indent inExperiment method from returning undefined #19739

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

debonte
Copy link

@debonte debonte commented Aug 26, 2022

Fix #19737

Pylance versions without semver prerelease tags were not handled correctly in the auto-indent experiment code I added yesterday.

Fixed inExperiment to not return undefined in this case.

@debonte debonte requested a review from karthiknadig August 26, 2022 00:22
@debonte debonte added the bug Issue identified by VS Code Team member as probable bug label Aug 26, 2022
@karthiknadig karthiknadig added the skip tests Updates to tests unnecessary label Aug 26, 2022
@debonte debonte merged commit cf70a15 into microsoft:main Aug 26, 2022
@debonte debonte deleted the inExperimentUndefined branch August 26, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language server fails to start
2 participants