Interactive window middleware for Pylance LSP notebooks #19501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
reviewed
Jul 19, 2022
src/client/activation/node/lspInteractiveWindowMiddlewareAddon.ts
Outdated
Show resolved
Hide resolved
rchiodo
previously approved these changes
Jul 19, 2022
karthiknadig
previously approved these changes
Jul 21, 2022
debonte
force-pushed
the
interactiveWindowMiddleware
branch
from
b5f0a64
to
b069e0a
Compare
karthiknadig
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of microsoft/vscode-jupyter#10630. Also requires changes in Jupyter and Pylance.
Add middleware that treats the input box text document of an Interactive Window as an additional notebook cell when the Pylance LSP notebooks experiment is enabled.
Jupyter PR: microsoft/vscode-jupyter#10865
Pylance PR: https://github.com/microsoft/pyrx/pull/2632