Ensure we register for interpreter change when moving from untrusted to trusted. #19351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heejaechang
reviewed
Jun 23, 2022
karrtikr
reviewed
Jun 23, 2022
karthiknadig
added
the
bug
karrtikr
approved these changes
Jun 24, 2022
debonte
approved these changes
Jun 24, 2022
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…to trusted. (microsoft/vscode-python#19351) * Ensure we register for interpreter change when moving from untrusted to trusted. * Tweak LanguageServerChangeHandler dispose * Use disposables instead on context.subscriptions for consistency. * Address comments. * Fix tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have moved some of the even registrations into
activate(). This is needed because whenever we change trust we calldeactivate()andactivatethe extension. This is to simulate the extension re-load.The cause is that object lifetime management currently is not straightforward due to the way we use
inversify. This is compounded by the fact that when inversify unloads, it does not call dispose on the objects. Then again inversify may not own the object that it is trying to dispose. For now hacks will have to do. Long term we will be rewriting the various parts of the extension to get rid ofinversifyand have better control over object life times. so we can actually dodeactivateandactivateto simulateWindows re-load.