Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve information collected by the Python: Report Issue command #19068

Merged
merged 4 commits into from
May 5, 2022

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented May 5, 2022

Closes #19067

@karrtikr karrtikr added the skip package*.json package.json and package-lock.json don't both need updating label May 5, 2022
@karrtikr karrtikr marked this pull request as ready for review May 5, 2022 17:55
Comment on lines 30 to +38
experiments
• enabled: true
• enabled: false
• optInto: []
• optOutFrom: []

venvPath: "<placeholder>"

pipenvPath: "<placeholder>"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old way.

Comment on lines +24 to +34
<summary>User Settings</summary>

<p>

```
Multiroot scenario, following user settings may not apply:

experiments
• enabled: false

venvPath: "<placeholder>"
Copy link
Author

@karrtikr karrtikr May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New behavior.

@karrtikr karrtikr merged commit e23801f into microsoft:main May 5, 2022
@karrtikr karrtikr deleted the addcom branch May 5, 2022 22:31
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this pull request May 10, 2022
…icrosoft#19068)

* Improve information collected by the `Python: Report Issue` command

* Fix package.json

* Add test

* Add test for multiroot
karthiknadig pushed a commit that referenced this pull request May 10, 2022
…19068)

* Improve information collected by the `Python: Report Issue` command

* Fix package.json

* Add test

* Add test for multiroot
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
…icrosoft/vscode-python#19068)

* Improve information collected by the `Python: Report Issue` command

* Fix package.json

* Add test

* Add test for multiroot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip package*.json package.json and package-lock.json don't both need updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve information collected by the Python: Report Issue command
2 participants