forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve information collected by the Python: Report Issue
command
#19068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrtikr
added
the
skip package*.json
package.json and package-lock.json don't both need updating
label
May 5, 2022
karrtikr
commented
May 5, 2022
Comment on lines
30
to
+38
experiments | ||
• enabled: true | ||
• enabled: false | ||
• optInto: [] | ||
• optOutFrom: [] | ||
|
||
venvPath: "<placeholder>" | ||
|
||
pipenvPath: "<placeholder>" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old way.
Comment on lines
+24
to
+34
<summary>User Settings</summary> | ||
|
||
<p> | ||
|
||
``` | ||
Multiroot scenario, following user settings may not apply: | ||
|
||
experiments | ||
• enabled: false | ||
|
||
venvPath: "<placeholder>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New behavior.
kimadeline
approved these changes
May 5, 2022
karthiknadig
pushed a commit
to karthiknadig/vscode-python
that referenced
this pull request
May 10, 2022
…icrosoft#19068) * Improve information collected by the `Python: Report Issue` command * Fix package.json * Add test * Add test for multiroot
karthiknadig
pushed a commit
that referenced
this pull request
May 10, 2022
…19068) * Improve information collected by the `Python: Report Issue` command * Fix package.json * Add test * Add test for multiroot
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…icrosoft/vscode-python#19068) * Improve information collected by the `Python: Report Issue` command * Fix package.json * Add test * Add test for multiroot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19067