Run Pyright for all workflows #18268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettcannon
approved these changes
Jan 10, 2022
Comment on lines
+58
to
+59
| # Using getattr instead of node.decorator_list or pyright will complain about an unknown member. | ||
| line_end -= len(getattr(node, "decorator_list")) |
There was a problem hiding this comment.
Can you report this as a bug on Pylance? That hasattr() check should cause the entire clause to mark the node object has having the decorator_list as an attribute.
There was a problem hiding this comment.
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
* Run Pyright for all workflows * Rename job * Remove special directory * analyze types only in pythonFiles * Install requirements * Fix indentation * Indentation, again * Try excluding lib form pyright * install debugger requirements, tweak extraPaths * Remove debugpy install * Exclude more files * Add more to pyproject.toml, install test reqs * Fix normalizeSelection * Move from exclude to ignore * Update build workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18267