Process iopub messages synchronously #12733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
requested review from
rchiodo,
IanMatthewHuff,
DavidKutu,
greazer,
joyceerhl and
techwithtim
DonJayamanne
commented
Jul 2, 2020
DonJayamanne
commented
Jul 2, 2020
| @@ -341,7 +341,7 @@ export class NotebookExecutionService implements INotebookExecutionService { | |||
| this.registeredIOPubListeners.add(nb); | |||
| //tslint:disable-next-line:no-require-imports | |||
| const jupyterLab = require('@jupyterlab/services') as typeof import('@jupyterlab/services'); | |||
| nb.registerIOPubListener(async (msg) => { | |||
There was a problem hiding this comment.
Was async as the original signature of the callback mandated this, now we don't need it to be async at all.
DonJayamanne
commented
Jul 2, 2020
…o issue12588 * 'issue12588' of github.com:DonJayamanne/pythonVSCode: Better way to determine the 'real' path for a file than assuming it's in a certain location (#12734) Add telemetry for 'Select Interpreter' command (#12723) Increase timeout for flaky tests & hooks (#12721) Drop Developer Tools from the bug issue template Add some logging to a flaky test (#12711) Special case failure for windows (#12714) Add link to python.dataScience.alwaysTrustNotebooks setting (#12702) Remove language server survey (#12677)
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #12588
At least in VS Code Notebooks, the improvement is fairly significant.
Down from 3minutes to 5 seconds.
Note: This doesn't completely resolve the slow times experienced in the existing Notebook Editor.
We have delays due to UI updates there (however that too is down from 3minutes to ~15 seconds).
That might probably need to be addressed separately.
Either way its a significantly improvement.