Support Update Display Data

[rchiodo]

For #10873

We've never handled the update_display_data message correctly as it can affect other cells. This is necessary to get some ipywidgets to work correctly.

[rchiodo]

Debating with myself if I should add a functional test for this. Probably makes sense to

[IanMatthewHuff]

Display data can update both execute_result and display_data outputs. I think you would need that here as well.
https://jupyter-client.readthedocs.io/en/stable/messaging.html#display-data

[rchiodo]

Will fix

[codecov-io]

Codecov Report

Merging #10874 into master will decrease coverage by 34.65%.
The diff coverage is 18.18%.

@@             Coverage Diff             @@
##           master   #10874       +/-   ##
===========================================
- Coverage   60.68%   26.02%   -34.66%     
===========================================
  Files         580      328      -252     
  Lines       31525    17530    -13995     
  Branches     4479     2498     -1981     
===========================================
- Hits        19130     4563    -14567     
- Misses      11425    12933     +1508     
+ Partials      970       34      -936     

Impacted Files	Coverage Δ
...rc/client/common/application/webPanels/webPanel.ts	11.84% <ø> (ø)
...ent/common/application/webPanels/webPanelServer.ts	12.67% <ø> (-61.98%)	⬇️
.../datascience/interactive-common/interactiveBase.ts	5.55% <0.00%> (-0.07%)	⬇️
...ience/interactive-common/interactiveWindowTypes.ts	100.00% <100.00%> (ø)
src/client/debugger/constants.ts	0.00% <0.00%> (-100.00%)	⬇️
src/client/language/braceCounter.ts	5.40% <0.00%> (-94.60%)	⬇️
src/client/language/textBuilder.ts	8.69% <0.00%> (-91.31%)	⬇️
src/client/language/characterStream.ts	4.41% <0.00%> (-89.71%)	⬇️
src/client/language/tokenizer.ts	4.08% <0.00%> (-89.22%)	⬇️
...t/terminals/codeExecution/terminalCodeExecution.ts	14.54% <0.00%> (-85.46%)	⬇️
... and 462 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e964f...5f1b982. Read the comment docs.

[IanMatthewHuff]

I think this is a case where we need to lazy load jupyterlab services.

[IanMatthewHuff]

Approved with lazy load of Jupyter, at least from my perspective.

[DonJayamanne]

@rchiodo do we need these changes even after my new ipywidget implementation?
I can see AML widget working.
However we have changes in our react code to deal with update display data. Is that still required?

[rchiodo]

@rchiodo do we need these changes even after my new ipywidget implementation?
I can see AML widget working.
However we have changes in our react code to deal with update display data. Is that still required?

Yes for other reasons. This code doesn't work without it but it does in jupyter:

# %%
import itertools
import time

from IPython.display import Markdown


# %%

dh = display(display_id=True)


# %%
display(Markdown('# Display Update Fun'))
dh.display(Markdown(''))


# %%
for i in itertools.cycle(range(0x1F600, 0x1F650)):
    dh.update(Markdown(f'## &#{i}; {hex(i)}'))
    time.sleep(0.5)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
2 Code Smells

No Coverage information
1.1% Duplication