Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python extension activates on any debug #57

Closed
LaurentTreguier opened this issue Nov 13, 2017 · 1 comment · Fixed by #220
Closed

Python extension activates on any debug #57

LaurentTreguier opened this issue Nov 13, 2017 · 1 comment · Fixed by #220
Labels
area-debugging bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@LaurentTreguier
Copy link

LaurentTreguier commented Nov 13, 2017

Environment data

VS Code version: 1.18.0
Python Extension version: 0.8.0
Python 2 Version: 2.7.14
Python 3 Version: 3.6.2
OS and version: Fedora 26 x86_64

Actual behavior

The extension always starts when debugging any kind of project.

Expected behavior

The extension probably shouldn't start when debugging projects that do not contain any python code.

Steps to reproduce:

  • Open a non-python project with a launch.json file
  • Start a debugging session with F5

From what I see in package.json's activation events, it looks like it's supposed to activate on any debugging session. However I don't see the point, as it only slows down debugging other projects.

I know I can just disable the extension for non-python projects, but that activation event still seems a bit overkill. Is there a reason for not using "workspaceContains:**/*.py" (and a few others for other extensions) instead ?

@DonJayamanne
Copy link

This was left as its possible to start debugging Python code even without having a Python file open (i.e. the activation was the debugger).
However, using "workspaceContains:**/*.py" should fix this.

@brettcannon brettcannon added area-debugging bug Issue identified by VS Code Team member as probable bug labels Nov 14, 2017
@DonJayamanne DonJayamanne added this to the December 2017 milestone Nov 17, 2017
DonJayamanne added a commit that referenced this issue Dec 14, 2017
* 'master' of https://github.com/Microsoft/vscode-python:
  Fixes #56 list all environments (#219)
  Fixes #57 Disable activation on debugging (#220)
  Fixes #26 Do not run linters when linters are disabled (#222)
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-debugging bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants