Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylint message template overridden by linter #382

Closed
AWPelican opened this issue Dec 9, 2017 · 6 comments
Closed

Pylint message template overridden by linter #382

AWPelican opened this issue Dec 9, 2017 · 6 comments
Labels
area-linting feature-request Request for new features or functionality

Comments

@AWPelican
Copy link

Environment data

VS Code version: 1.18.1
Python Extension version: 0.8.0
Python Version: 3.6.3
OS and version: Fedora 26

Actual behavior

I was trying to set the --msg-template argument in python.linting.pylintArgs, but found that there were, surprisingly, no changes in the VS Code linter pop-ups or console output.

Oluwafemi Sule pointed out in his answer to my StackOverflow question that the message template is actually hardcoded into the linter for Pylint.

Expected behavior

I would have expected that passing in a --msg-template argument would have allowed me to change the format of the Pylint messages in the linter.

As a side note, it appears the Pylint project favors using the message symbol (e.g. 'trailing-whitespace') over the message msg_id (e.g. 'C0303') that is currently used in Visual Studio Code, per the examples in its documentation its default message template since pylint 1.0, and this FAQ answer.

@AWPelican AWPelican changed the title Pylint Message Template for Linter Pylint message template for linter Dec 9, 2017
@AWPelican AWPelican changed the title Pylint message template for linter Pylint msg-template argument overridden by linter Dec 9, 2017
@AWPelican AWPelican changed the title Pylint msg-template argument overridden by linter Pylint message template overridden by linter Dec 9, 2017
@brettcannon brettcannon added awaiting 1-decision area-linting feature-request Request for new features or functionality labels Dec 11, 2017
@brettcannon
Copy link
Member

I believe we control --msg-template so we can read the output from Pylint itself, otherwise we can't parse the response to use the results.

@DonJayamanne
Copy link

We could improve the linter message to include the message symbol (e.g. 'trailing-whitespace')

@AWPelican
Copy link
Author

That sounds good to me. My main interest here was just that--to allow a quick way to see the human-readable message symbol.

@brettcannon
Copy link
Member

I think it's a reasonable idea to include the human-readable message since Pylint has been slowly shifting that way itself.

@jcdyer
Copy link

jcdyer commented Dec 29, 2017

I've got a PR for this up at #495.

@MikhailArkhipov MikhailArkhipov self-assigned this Feb 1, 2018
@MikhailArkhipov MikhailArkhipov added this to the February 2018 milestone Feb 1, 2018
@MikhailArkhipov MikhailArkhipov removed their assignment Feb 26, 2018
@brettcannon brettcannon modified the milestones: February 2018, March 2018 Mar 5, 2018
@brettcannon brettcannon added this to the May 2018 milestone Apr 9, 2018
@brettcannon brettcannon modified the milestones: May 2018, June 2018 May 7, 2018
@brettcannon brettcannon removed this from the June 2018 milestone Jun 4, 2018
@brettcannon
Copy link
Member

To help manage our issues and to better communicate what the team plans to work on we are closing issues that we don't plan to work on but would accept a pull request from a volunteer for. To be clear, closing this issue does not mean we won't consider a pull request for this enhancement as outlined in our contributing guide, just that the development team has no plans to work on it themselves.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-linting feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants