Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test are not automatically refreshed after pytest installation #21124

Closed
karthiknadig opened this issue Apr 25, 2023 · 5 comments
Closed

Test are not automatically refreshed after pytest installation #21124

karthiknadig opened this issue Apr 25, 2023 · 5 comments
Assignees
Labels
area-testing bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team verified Verification succeeded
Milestone

Comments

@karthiknadig
Copy link
Member

karthiknadig commented Apr 25, 2023

Testing #21092

After opening the test repository, create environment and trigger testing. Test does not show failed output with missing pytest.

After installing pytest, it does not automatically refresh.

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Apr 25, 2023
@Yoyokrazy Yoyokrazy mentioned this issue Apr 25, 2023
4 tasks
@eleanorjboyd
Copy link
Member

noting this is a regression in the new testing rewrite

eleanorjboyd added a commit that referenced this issue Apr 26, 2023
works on #21124 but is
only half the solution.
@eleanorjboyd eleanorjboyd added this to the April 2023 milestone Apr 26, 2023
@eleanorjboyd eleanorjboyd added the verification-needed Verification of issue is requested label Apr 26, 2023
@eleanorjboyd
Copy link
Member

fixed by #21133

@eleanorjboyd eleanorjboyd added bug Issue identified by VS Code Team member as probable bug area-testing and removed triage-needed Needs assignment to the proper sub-team labels Apr 26, 2023
@rzhao271 rzhao271 added verified Verification succeeded verification-found Issue verification failed and removed verified Verification succeeded labels Apr 26, 2023
@rzhao271
Copy link

When I start with no venv, I first create a venv Python environment. Then, I navigate to the testing panel and configure pytest tests. I then notice that pytest is installed, but the tests don't refresh, and pressing the refresh button doesn't load the tests, either.

@rzhao271 rzhao271 reopened this Apr 26, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Apr 26, 2023
@eleanorjboyd
Copy link
Member

Sorry this needs tomorrow's insiders release and a specific testing constant- will switch to author verification and have @karthiknadig look at it tomorrow. Thanks!

@eleanorjboyd eleanorjboyd added author-verification-requested Issues potentially verifiable by issue author and removed verification-needed Verification of issue is requested verification-found Issue verification failed labels Apr 26, 2023
@eleanorjboyd
Copy link
Member

verification steps:

  1. launch vscode with the environment variable ENABLE_PYTHON_TESTING_REWRITE = '1'
  2. use the create environment command from the command palette, select venv and whatever python version you want >=3.7 (your environment needs to not have pytest installed so you can use an existing one but this condition just has to be met)
  3. click on the test icon to pull up test discovery, check to make sure the error message looks right
  4. install pytest, make sure it re-finds tests after install

@eleanorjboyd eleanorjboyd added verification-needed Verification of issue is requested and removed author-verification-requested Issues potentially verifiable by issue author labels Apr 27, 2023
@github-actions github-actions bot added the info-needed Issue requires more information from poster label Apr 27, 2023
@Yoyokrazy Yoyokrazy added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Apr 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants