Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reliably and quickly fetch activated environment variables for conda #19987

Open
karrtikr opened this issue Oct 11, 2022 · 2 comments
Open

Reliably and quickly fetch activated environment variables for conda #19987

karrtikr opened this issue Oct 11, 2022 · 2 comments
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs PR Ready to be worked on

Comments

@karrtikr
Copy link

karrtikr commented Oct 11, 2022 •
edited
Loading

conda run is more reliable than conda activate : #19967
conda activate command is much faster than conda run : conda/conda#11814

We could do a mixture of these two approaches in the extension and return which ever came back with the environment variables faster.

However note this can change with #11039, where we potentially get rid of using conda activate commands, so it's best to tackle this issue after that.
@karrtikr karrtikr added feature-request Request for new features or functionality area-environments Features relating to handling interpreter environments needs PR Ready to be worked on labels Oct 11, 2022
@karrtikr karrtikr mentioned this issue Oct 11, 2022
Merged
karrtikr pushed a commit that referenced this issue Oct 12, 2022
Revert to using conda run for fetching activated environment variab…
38d8d9c 
…les (#19986)

Reverts #19819 Closes
#19967

Until we have a better activation story:
#11039, where we
potentially get rid of using `conda activate` commands, use `conda run`
for fetching environment variables even though it's slower.

Created #19987 for
tackling it in the future.

FYI @DonJayamanne
karrtikr pushed a commit that referenced this issue Oct 12, 2022
Revert to using conda run for fetching activated environment variab…
d1126d5 
…les (#19986)

Reverts #19819 Closes
#19967

Until we have a better activation story:
#11039, where we
potentially get rid of using `conda activate` commands, use `conda run`
for fetching environment variables even though it's slower.

Created #19987 for
tackling it in the future.

FYI @DonJayamanne
@fulcus
Copy link

fulcus commented Mar 16, 2023 •
edited
Loading

#19967 is not fixed, I am still getting the same error on prerelease v2023.5.10741016

We failed to start a TensorBoard session due to the following error: Command failed: conda run -n cv --no-capture-output python /Users/fulco/.vscode/extensions/ms-python.python-2023.5.10741016/pythonFiles/get_output_via_markers.py /Users/fulco/.vscode/extensions/ms-python.python-2023.5.10741016/pythonFiles/printEnvVariables.py bash: conda: command not found

@karrtikr
Copy link
Author

That is not the same error as #19967. Please open a new issue and we'll be happy to look into it.

wesm pushed a commit to posit-dev/positron that referenced this issue Mar 28, 2024
@wesm
Revert to using conda run for fetching activated environment variab…
210b604 
…les (microsoft/vscode-python#19986)

Reverts microsoft/vscode-python#19819 Closes
microsoft/vscode-python#19967

Until we have a better activation story:
microsoft/vscode-python#11039, where we
potentially get rid of using `conda activate` commands, use `conda run`
for fetching environment variables even though it's slower.

Created microsoft/vscode-python#19987 for
tackling it in the future.

FYI @DonJayamanne
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs PR Ready to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karrtikr @fulcus