forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controlled rollout of notifying about the black
/pylint
/isort
extension.
#19653
Labels
area-formatting
area-linting
author-verification-requested
Issues potentially verifiable by issue author
feature-request
Request for new features or functionality
needs PR
Ready to be worked on
verification-needed
Verification of issue is requested
verified
Verification succeeded
Milestone
Comments
black
/pylint
/isort
extension.black
/pylint
/isort
extension.
@luabud How does this look like for the transition to extension? flowchart TD
start([start])
finished([end])
is_linter_enabled{Is Linter Enabled?}
has_args{Has Linter args?}
are_simple_args{Are simple args?}
install_extensions{Install extensions?}
show_prompt[Show prompt]
no_prompt[No prompt]
trigger_install[trigger install]
copy_args[Copy arguments]
start --> is_linter_enabled
is_linter_enabled -- yes --> has_args
is_linter_enabled -- no --> no_prompt
has_args -- yes --> are_simple_args
has_args -- no --> show_prompt
are_simple_args -- yes --> show_prompt
are_simple_args -- no --> no_prompt
show_prompt --> install_extensions
install_extensions -- no --> finished
install_extensions -- yes --> trigger_install
trigger_install --> copy_args
copy_args --> finished
no_prompt --> finished
|
This looks good to me! If users don't have args, wouldn't we want to transition them to the new extensions as well? |
27 tasks
This was referenced Sep 4, 2022
34 tasks
39 tasks
34 tasks
41 tasks
20 tasks
41 tasks
karthiknadig
added a commit
that referenced
this issue
Mar 16, 2023
@luabud Can you verify this when you get the chance for Formatting prompt? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-formatting
area-linting
author-verification-requested
Issues potentially verifiable by issue author
feature-request
Request for new features or functionality
needs PR
Ready to be worked on
verification-needed
Verification of issue is requested
verified
Verification succeeded
isort
: We decided to replace theisort
shipped with the extension to just useisort
extension.black
/autopep8
: We have to prompt users for each selected formatter.pylint
/flake8
: We have to prompt users for each selected linter.The text was updated successfully, but these errors were encountered: