Consolidate tree views #966
Conversation
|
The code looks good in overall (I'll take detailed review later) but it seems we didn't handle restoring from review mode when first launch. For example, we checkout to a branch and start reviews, and then reload the window, navigate to the GitHub viewlet, all trees are collapsed. It requries two expands at least (expand category first, find the pr with checkmark if it's not on the second page, expand that pr) to review the code changes again. |
| @@ -98,6 +99,9 @@ export const onDidSubmitReview: vscode.Event<Comment[]> = _onDidSubmitReview.eve | |||
| export class PullRequestManager { | |||
| static ID = 'PullRequestManager'; | |||
| private _activePullRequest?: PullRequestModel; | |||
| public activeFileChanges?: GitFileChange[]; | |||
| public activeOutdatedFileChanges?: GitFileChange[]; | |||
| public activeComments?: Comment[]; | |||
| private _credentialStore: CredentialStore; | |||
There was a problem hiding this comment.
Not a fan of having view info in PullRequestManager. We can probably keep the information in prsTreeDataProvider. The ReviewManager takes care of git status change, and modifying PullRequestManager.activePullRequest, prsTreeDataProvider then listens to activePullRequest change event and reveal/refresh the tree when necessary.
#965
Removes the "Changes in Pull Request" tree view