Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support opening a pull request by number #266

Closed
roblourens opened this issue Aug 24, 2018 · 8 comments · Fixed by #3106
Closed

Support opening a pull request by number #266

roblourens opened this issue Aug 24, 2018 · 8 comments · Fixed by #3106
Assignees
Labels
feature-request Request for new features or functionality on-testplan
Milestone

Comments

@roblourens
Copy link
Member

If I know that I want to see pull request 123, it would be helpful if I could just put in the number instead of looking for it in a list.

@RMacfarlane RMacfarlane added the feature-request Request for new features or functionality label Aug 24, 2018
@auchenberg
Copy link
Contributor

Maybe via a command?

@kieferrm kieferrm mentioned this issue Jan 14, 2019
20 tasks
@RMacfarlane
Copy link
Contributor

@roblourens Are you imagining this would just open the description page of the pull request, or change the tree view as well?

@roblourens
Copy link
Member Author

Maybe both? But the PR can exist in multiple places in the tree, that might not be easy

@kieferrm kieferrm mentioned this issue Feb 6, 2019
8 tasks
@rebornix rebornix added the help wanted Issues identified as good community contribution opportunities label Feb 13, 2019
@meaghanlewis meaghanlewis mentioned this issue Mar 4, 2019
7 tasks
@meaghanlewis
Copy link
Member

It seems like we still need to decide on the user experience here. In today's team sync we talked about opening the PR overview page.

@rbuckton
Copy link
Member

rbuckton commented Sep 8, 2020

My current workaround is to add a custom query:

    "githubPullRequests.queries": [
        {
            "label": "Specific Pull Request",
            "query": "is:open 40350"
        }
    ],

I could see a GitHub Pull Requests: View Pull Request... that prompted for the PR ID and added an entry into the Pull Requests list with a context-menu item to remove it. With such a feature someone could also theoretically write a Chrome/Edge Extension that adds an "Open PR In VS Code" button to GitHub that could launch VS Code and show the PR.

@RikkiGibson
Copy link
Member

I feel like it could be reasonable to introduce a "special" tree view entry at the top level which accepts text input. For example

  • a PR number
  • a PR url
  • an ad-hoc query

CodeStream has a similar feature.
pr-from-url

@alexr00 alexr00 self-assigned this Nov 16, 2021
@alexr00 alexr00 removed the help wanted Issues identified as good community contribution opportunities label Nov 16, 2021
@alexr00 alexr00 added this to the November 2021 milestone Nov 16, 2021
alexr00 added a commit that referenced this issue Nov 16, 2021
alexr00 added a commit that referenced this issue Nov 16, 2021
@alexr00
Copy link
Member

alexr00 commented Nov 16, 2021

The new command is accessible from the command palette and the PRs view.

@roblourens
Copy link
Member Author

Yesssssss

@alexr00 alexr00 added verification-needed Verification of issue is requested and removed verification-needed Verification of issue is requested labels Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants