Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Debug launch should gracefully fail on older versions of Node #26

Closed
mousetraps opened this issue Sep 27, 2016 · 6 comments
Closed

Debug launch should gracefully fail on older versions of Node #26

mousetraps opened this issue Sep 27, 2016 · 6 comments

Comments

@mousetraps
Copy link

mousetraps commented Sep 27, 2016

Testing microsoft/vscode#12600

Node v6.2.1 x64 on Windows attempts to run:
node --inspect=13471 --debug-brk --nolazy server.js

Expected: helpful and actionable error message about an unsupported version

Actual: debug fails with following cryptic message to debug console

node --inspect=9286 --debug-brk --nolazy server.js 
node: bad option: --inspect=9286
@mousetraps
Copy link
Author

Ooh, actually v6.3.1 is supported - updating this issue to reflect the actual error message printed w/ older versions of node, and creating another issue to track the v6.3 issue
#27

@roblourens
Copy link
Member

Yeah I was trying to decide whether to query node --version and try to tell the user that it won't be supported, or detect that exact output in stderr and give something better, or leave it up to the user. Can probably do better.

@roblourens
Copy link
Member

I'm going to close this for now because it just adds complexity to the startup process, and can't handle things like 'attach' anyway, but if lots of people complain maybe we'll have to do something about it. Or when it's no longer 'experimental'.

@mousetraps
Copy link
Author

@roblourens this seems like something that should definitely be addressed when it moves out of being experimental (ppl don't upgrade node versions that frequently), so not sure what good it does to push the work fwd. If it adds complexity, it would probably be best to get as much testing as possible before it becomes official.

@roblourens
Copy link
Member

Yeah let's reopen it. It has definitely come up in node-debug issues where we've been encouraging people to try node2.

@roblourens roblourens reopened this Oct 25, 2016
@roblourens
Copy link
Member

Now that it's no longer 'experimental', we expect people to use the 'auto' option, which makes this hopefully not a problem.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 29, 2018
Shenniey pushed a commit to Shenniey/vscode-node-debug2 that referenced this issue Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants