Fix release notes and 1 config option #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kevcunnane
commented
Feb 23, 2017
kevcunnane
commented
- Config option was not setup to support discovery of the "saveAsCsv.IncludeHeaders" option - it only gave an empty object instead of the true/false option that's standard for other settings. Updated & verified that the option is still correctly passed through to the SqlToolsService
- Updated release notes, readme & changelog to reflect new release
- Updated Readme to include all config options
- Config option was not setup to support discovery of the "saveAsCsv.IncludeHeaders" option - it only gave an empty object instead of the true/false option that's standard for other settings. Updated & verified that the option is still correctly passed through to the SqlToolsService - Updated release notes, readme & changelog to reflect new release - Updated Readme to include all config options
|
@kevcunnane, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kburtram, @erickangMSFT and @anthonydresser to be potential reviewers. |
|
@kevcunnane, |
kburtram
reviewed
Feb 23, 2017
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| <h2 id="7">Version 0.3.0</h2> | |||
| <ul> | |||
| <li>Release date: February, 2016</li> | |||
| <li>Release date: February 24, 2016</li> | |||
There was a problem hiding this comment.
li>Release date: February 24, 2016< [](start = 1, length = 35)
still haven't removed this file yet? we should switch to popping up a web page for the next release.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.