Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain query messages when switching tabs #17999

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Retain query messages when switching tabs #17999

merged 1 commit into from
Aug 27, 2024

Conversation

kburtram
Copy link
Member

Fixes #1753

@kburtram kburtram requested review from cssuh and caohai August 27, 2024 00:51
@github-actions GitHub Actions
Copy link

VSIX Size Comparison

  • Main branch VSIX size: 11679 KB
  • PR branch VSIX size: 11303 KB
  • Size difference: -376 KB (-3%)

React Webview Bundle Size Comparison

  • Main branch bundle size: 2080 KB
  • PR branch bundle size: 872 KB
  • Size difference: -1208 KB (-58%)

@Charles-Gagnon
Copy link
Contributor

@aasimkhan30 Is the -58% size difference for the webview bundle size comparison expected? It doesn't seem like the changes here should result in a change that massive. (even the -3% VSIX size difference seems like a lot for a couple line change)

@kburtram kburtram merged commit b32ac94 into main Aug 27, 2024
7 checks passed
@kburtram kburtram deleted the dev/karlb/retainmsg branch August 27, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cssuh cssuh cssuh approved these changes

@caohai caohai Awaiting requested review from caohai caohai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL Messages need to persist and be accurate
3 participants
@kburtram @Charles-Gagnon @cssuh