-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Apple Silicon #16969
Conversation
Updated platform to support Apple Silicon (arm64). Fixes issue 16967
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I have the power to "approve" as such, but I built Dave's code and I now have a functioning mssql extension on my M1 Mac. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. we're not build a copy of SQL Tools Service specifically for ARM, so does this mean the Intel build of those binaries are able to run on Apple Silicon systems? (I don't have access to a machine with this chipset to verify)
@abist could you please work with @davemcdermid to merge assuming this correctly enables support for Apple Silicon systems? |
Yep, SQL Tools seems to run just fine under Rosetta2. Not tested extensively, but so far it's been good for me. |
@davemcdermid Thanks for the PR! Like @kburtram mentioned, the service behind the extension uses Intel build binaries, so let me test out all the features and let's get it in once we confirm it all works as expected 😃 |
Bump Who has the power to merge this in? |
@abist I don't see any reason not to merge this. Are you waiting on anything with this? |
Can a release be created so that this fix is available to M1 users? |
does this run native on apple silicon? or does it require rosetta? |
@mikeelston The fix was to continue to use Intel (x64) builds for SQL tools when the extension is running in VSCode natively on Apple Silicon. So, the extension is running natively, but the tools it runs are running under Rosetta2 |
Updated platform to support Apple Silicon (arm64).
Fixes issue 16967