-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a when clause to the contributed explorer view such that it is only activated when the workspace has a pom.xml file #549
Comments
Would it also be possible to add a name, contextualTitle, and icon? these would greatly benefit people who move the view into the Activity Bar like myself. https://code.visualstudio.com/api/references/contribution-points#contributes.views |
We used to do that, but later we decided to always show it. We received feedbacks from users (new to vscode) that they don't know how to start from scratch (e.g. create a maven project). The shortcut button (+) in the view proves to be helpful. But I do agree that if you are focusing on a non-java project(e.g. Python), it shouldn't bother you. My rough idea now is:
|
Could there be a setting for advanced users such that we only see the view when a pom.xml exists? Or maybe just restrict to showing the view when there are java files in the workspace? Be less restrictive than looking explicitly for a pom.xml, which would maybe get the best of both worlds since users could create a maven project now that view is there, and advanced users wouldn't see it in non-java projects. |
@Eskibear if I want to also get #549 (comment) resolved, should I make a separate ticket? Thanks for implementing at least the when clause! Very helpful! |
I'm fixing it now. |
Describe the bug
The extension contributes its view when not in a Maven project. Currently in a Python project without anything to do with Java and I see the view contribution.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Don't show view when not in a Maven project (no pom.xml).
Environments (please complete the following information as much as possible):
Additional context
https://github.com/microsoft/vscode-maven/blob/master/package.json#L191
microsoft/vscode-java-test#793
microsoft/vscode-java-test#793 (comment)
microsoft/vscode-java-dependency#372
The text was updated successfully, but these errors were encountered: