Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

there was a bug where the first argument wasn't adding a space in front #530

Merged
merged 4 commits into from
Nov 20, 2023
Merged

there was a bug where the first argument wasn't adding a space in front #530

merged 4 commits into from
Nov 20, 2023

Conversation

gcampbell-msft
Copy link
Collaborator

@gcampbell-msft gcampbell-msft commented Nov 20, 2023 •
edited
Loading

see title.

This was referenced Nov 20, 2023
Closed
Closed
benmcmorran
benmcmorran approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@benmcmorran benmcmorran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to split this into two PRs, but I'm not blocking on that.

@gcampbell-msft
Copy link
Collaborator Author

You might want to split this into two PRs, but I'm not blocking on that.

This is a good reminder, I'll leave it as one but if anything regresses this may be the one to take a look at. Thanks.

@gcampbell-msft gcampbell-msft merged commit 01305ea into main Nov 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmcmorran benmcmorran benmcmorran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gcampbell-msft @benmcmorran