Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy to clipboard when creating share link #147

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Copy to clipboard when creating share link #147

merged 3 commits into from
Mar 17, 2023

Conversation

jwunderl
Copy link
Member

Handles a few of the minor tweaks listed at the bottom of #146 -- copying to clipboard and aligning the language of the command. I left it emitting to the output window for now as a new link is generated every time / to match a bit closer with how it's shown in the webapp where we do show the link after it is generated:

image

I also noticed from the suggestion that commands in vscode tend to use title case for labels, so I'll do quick a pass updating that separately, as well as look at why it looks like we're activating the extension at all times and not just when these conditions are met https://github.com/microsoft/vscode-makecode/blob/main/package.json#L26

@jwunderl jwunderl requested review from abchatra and riknoll March 17, 2023 20:31
@joyceerhl
Copy link

why it looks like we're activating the extension at all times and not just when these conditions are met

The Extension Host output channel should have printed a message when MakeCode got activated with the activation reason. Possibly microsoft/vscode#173992

@jwunderl
Copy link
Member Author

why it looks like we're activating the extension at all times and not just when these conditions are met

The Extension Host output channel should have printed a message when MakeCode got activated with the activation reason. Possibly microsoft/vscode#173992

Ah perfect thank you, you're correct that it's activating onLanguage:json, which would come from that issue as we do contribute .jres as an extension used for storing assets (images / songs / etc) https://github.com/microsoft/vscode-makecode/blob/main/package.json#L291.

2023-03-17 13:51:39.039 [info] Extension host started
2023-03-17 13:51:39.041 [info] ExtensionService#_doActivateExtension ms-edu.pxt-vscode-web, startup: false, activationEvent: 'onLanguage:json'
2023-03-17 13:51:39.209 [info] Eager extensions activated

@jwunderl jwunderl merged commit be3cef3 into main Mar 17, 2023
@jwunderl jwunderl deleted the copyToClipboard branch March 17, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants