Copy to clipboard when creating share link #147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles a few of the minor tweaks listed at the bottom of #146 -- copying to clipboard and aligning the language of the command. I left it emitting to the output window for now as a new link is generated every time / to match a bit closer with how it's shown in the webapp where we do show the link after it is generated:
I also noticed from the suggestion that commands in vscode tend to use title case for labels, so I'll do quick a pass updating that separately, as well as look at why it looks like we're activating the extension at all times and not just when these conditions are met https://github.com/microsoft/vscode-makecode/blob/main/package.json#L26