Allow resultReporter to be substituted in provideWorkspaceDiagnostics middleware. #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dbaeumer You were suggested as someone who might could review this. We are looking at allowing C# users to optionally turn information diagnostics into hint diagnostics and this is blocking us. |
dbaeumer
approved these changes
Sep 27, 2024
|
@JoeRobich great catch. |
mjbvz
approved these changes
Sep 27, 2024
|
@dbaeumer Would it be possible to get a new .next release with this change in it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not accepting a
resultReporterparameter inprovideDiagnosticstheprovideWorkspaceDiagnosticsmiddleware always used the reporter it was initially passed. This means that diagnostics are always reported without the ability to manipulate them first.