-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No LSP workspace/didChangeConfiguration
notifications after language server restart
#1295
Comments
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.81.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding! |
I checked and the problem still exists on 1.81.1 |
More info: the extension is currently build with vscode-languageclient 8.1.0 and targets vscode engine ^1.75.0 |
I was able to reproduce this however the fix might cause some other problems so I need to think if the taken approach is a proper solution. If I produce a next release would you be willing to use it? |
Sure |
…ter language server restart (#1298)
@dbaeumer when can I expect a new release? |
I am in the process of creating one. Might still take a little |
Release 8.2.0-next.2 for client and server. |
Does this issue occur when all extensions are disabled?: Yes
I'm the autor of https://github.com/elixir-lsp/vscode-elixir-ls. Recently VSCode stopped sending
workspace/didChangeConfiguration
after server restart, which resulted in open tickets (elixir-lsp/vscode-elixir-ls#366, elixir-lsp/vscode-elixir-ls#345). Up until now the extension relied onLanguageClientOptions.synchronize.configurationSection
which turned out to be deprecated (#620). It seems the recent change is affecting other language servers (e.g. haskell/vscode-haskell#920) and some are downgrading the language server client package (haskell/vscode-haskell#934).I started migrating to
workspace/configuration
request and dynamic registration ofworkspace/didChangeConfiguration
as advised in microsoft/language-server-protocol#676 and while I'm able to get configuration that way there is a problem with notifications. Even if I explicitly register forworkspace/didChangeConfiguration
viaclient/registerCapability
, VSCode does not send LSPworkspace/didChangeConfiguration
notifications after language server restart.Steps to Reproduce:
workspace/didChangeConfiguration
via dynamic capability registrationThe text was updated successfully, but these errors were encountered: