Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send test telemetry to unchecked method #9775

Merged
merged 4 commits into from
Apr 26, 2022
Merged

Conversation

amunger
Copy link
Contributor

@amunger amunger commented Apr 25, 2022

Fixes #9218

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@amunger amunger requested a review from a team as a code owner April 25, 2022 23:44
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2022

Codecov Report

Merging #9775 (c26bb7b) into main (932943c) will decrease coverage by 0%.
The diff coverage is n/a.

❗ Current head c26bb7b differs from pull request most recent head 13b8eb0. Consider uploading reports for the commit 13b8eb0 to get more accurate results

@@         Coverage Diff          @@
##           main   #9775   +/-   ##
====================================
- Coverage    63%     63%   -1%     
====================================
  Files       203     203           
  Lines      9810    9810           
  Branches   1556    1556           
====================================
- Hits       6218    6214    -4     
- Misses     3093    3100    +7     
+ Partials    499     496    -3     
Impacted Files Coverage Δ
...rc/platform/common/dataScienceSurveyBanner.node.ts 65% <0%> (-6%) ⬇️
...ommon/process/environmentActivationService.node.ts 70% <0%> (+<1%) ⬆️

@amunger amunger force-pushed the dev/aamunger/testTelemetry2 branch from 8226f2d to c26bb7b Compare April 26, 2022 18:28
@amunger amunger merged commit e663bda into main Apr 26, 2022
@amunger amunger deleted the dev/aamunger/testTelemetry2 branch April 26, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable queries on test run history
3 participants