-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reopening a remote kernel #8510
Conversation
Oh and I also changed the UI a little bit. Old UI shows this for remote kernels in the selector: I changed it so that the notebook path was part of the real name: The reason for this is because there's no way to tell you're connected to an already running kernel in the notebook without it. All of the kernels look the same: Whereas now the existing ones will look like this: |
Codecov Report
@@ Coverage Diff @@
## main #8510 +/- ##
=====================================
- Coverage 71% 71% -1%
=====================================
Files 377 378 +1
Lines 23920 23982 +62
Branches 3681 3691 +10
=====================================
+ Hits 17204 17225 +21
- Misses 5225 5270 +45
+ Partials 1491 1487 -4
|
Fixes #7610
Made a new event on the controller indicating when remote kernels are refreshed. This allows me to listen for that and update a memento setting for the kernel id.
Initially I had attempted to just do that for all kernel starts, but the notebookcontrollermanager doesn't have the kernel at that point so there's no way to tell which notebook it's for. I needed an event that fired AFTER the controller has updated because of kernel start.