Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostic provider for '!pip install' and `!conda install' #8255

Merged
merged 5 commits into from
Nov 16, 2021

Conversation

DonJayamanne
Copy link
Contributor

For #6864

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

Merging #8255 (a1654f4) into main (645147d) will increase coverage by 0%.
The diff coverage is 88%.

@@          Coverage Diff           @@
##            main   #8255    +/-   ##
======================================
  Coverage     72%     72%            
======================================
  Files        370     371     +1     
  Lines      22835   22957   +122     
  Branches    3472    3493    +21     
======================================
+ Hits       16451   16550    +99     
- Misses      4954    4965    +11     
- Partials    1430    1442    +12     
Impacted Files Coverage Δ
...client/datascience/notebook/diagnosticsProvider.ts 88% <88%> (ø)
src/client/common/utils/localize.ts 95% <100%> (+<1%) ⬆️
src/client/datascience/notebook/serviceRegistry.ts 100% <100%> (ø)
...atascience/interactive-window/interactiveWindow.ts 63% <0%> (-2%) ⬇️
.../datascience/editor-integration/codeLensFactory.ts 87% <0%> (-2%) ⬇️
src/client/datascience/baseJupyterSession.ts 75% <0%> (-1%) ⬇️
...lient/datascience/jupyter/kernels/cellExecution.ts 73% <0%> (-1%) ⬇️
src/client/debugger/jupyter/kernelDebugAdapter.ts 82% <0%> (+<1%) ⬆️
src/client/ioc/container.ts 100% <0%> (+13%) ⬆️

@DonJayamanne DonJayamanne marked this pull request as ready for review November 15, 2021 19:54
@DonJayamanne DonJayamanne requested a review from a team as a code owner November 15, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants