Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when using unsupported python kernel versions #8214

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Warn when using unsupported python kernel versions #8214

merged 2 commits into from
Nov 10, 2021

Conversation

DonJayamanne
Copy link
Contributor

For #7960

@DonJayamanne DonJayamanne marked this pull request as ready for review November 10, 2021 16:20
@DonJayamanne DonJayamanne requested a review from a team as a code owner November 10, 2021 16:20
IanMatthewHuff
IanMatthewHuff reviewed Nov 10, 2021
View reviewed changes
package.nls.json Outdated
@@ -26,6 +26,7 @@
"DataScience.installPythonNonMarkdown": "Python is not installed. \nPlease download and install Python in order to execute cells in this notebook from here https://www.python.org/downloads.",
"DataScience.installKernel": "The Jupyter Kernel '{0}' could not be found and needs to be installed in order to execute cells in this notebook.",
"DataScience.customizeLayout": "Customize Layout",
"DataScience.wanrWhenSelectingKernelWithUnSupportedPythonVersion": "The version of Python associated with the selected kernel is no longer supported. Please consider selecting a different kernel.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wanr => warn

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2021 •
edited
Loading

Codecov Report

Merging #8214 (b70f79b) into main (ff8acb2) will increase coverage by 0%.
The diff coverage is 66%.

❗ Current head b70f79b differs from pull request most recent head a429a7b. Consider uploading reports for the commit a429a7b to get more accurate results

@@          Coverage Diff          @@
##            main   #8214   +/-   ##
=====================================
  Coverage     71%     71%           
=====================================
  Files        368     368           
  Lines      22598   22606    +8     
  Branches    3419    3422    +3     
=====================================
+ Hits       16195   16229   +34     
+ Misses      5004    4982   -22     
+ Partials    1399    1395    -4
Impacted Files Coverage Δ
...t/datascience/notebook/vscodeNotebookController.ts 75% <60%> (-1%) ⬇️
src/client/common/utils/localize.ts 95% <100%> (+<1%) ⬆️
.../datascience/notebook/notebookControllerManager.ts 73% <100%> (-1%) ⬇️
...ence/notebook/intellisense/intellisenseProvider.ts 85% <0%> (-4%) ⬇️
src/client/debugger/jupyter/kernelDebugAdapter.ts 82% <0%> (-1%) ⬇️
src/client/api/types.ts 100% <0%> (ø)
src/client/common/types.ts 100% <0%> (ø)
src/client/api/pythonApi.ts 69% <0%> (ø)
src/client/common/installer/productNames.ts 100% <0%> (ø)
... and 12 more

@DonJayamanne DonJayamanne merged commit cfa54b2 into main Nov 10, 2021
@DonJayamanne DonJayamanne deleted the issue7960 branch November 10, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchiodo rchiodo rchiodo approved these changes

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DonJayamanne @codecov-commenter @IanMatthewHuff @rchiodo