Set session name for the remote sessions created #438
Conversation
| @@ -85,7 +107,12 @@ export class JupyterSession extends BaseJupyterSession { | |||
| newSession = this.sessionManager.connectTo(kernelConnection.kernelModel.session); | |||
There was a problem hiding this comment.
Looks like we're already connecting to an existing session.
However with the new remote experience, we'll do this ONLY if the paths match.
I.e. if opening a notebook b.ipynb and trying to connect to session a.ipynb, then we will start a new session (but use the same kernel connection) - this is what Jupyter does.
Will only do that for new remote experience (where files and jupyter are on the same server)
This is because the paths for old remote experience is always unique (guid).
| @@ -69,6 +69,7 @@ export class JupyterSessionManager implements IJupyterSessionManager { | |||
| public async startNew( | |||
| kernelConnection: KernelConnectionMetadata | undefined, | |||
| workingDirectory: string, | |||
| uri?: string, | |||
There was a problem hiding this comment.
Using a string, as that's whats being passed in other places, a string.
DonJayamanne
requested review from
rchiodo,
IanMatthewHuff,
DavidKutu,
greazer,
joyceerhl and
a team
|
@joyceerhl @rchiodo @DavidKutu oops, this is an important change. |
For #254 (comment)
Will add tests separately (updated above todo list).
Currently there are other issues in this branch & would like to get things working before I add tests.
Apologies, please approve even if there are no tests (will add later)
Hence this change makes no different in classic jupyter.