Add logging to determine why variable tests were timing out #4189
Conversation
| @@ -177,7 +178,7 @@ export abstract class BasePythonDaemon { | |||
| return Object.keys(options).every((item) => daemonSupportedSpawnOptions.indexOf(item as any) >= 0); | |||
| } | |||
| protected sendRequestWithoutArgs<R, E, RO>(type: RequestType0<R, E, RO>): Thenable<R> { | |||
| if (this.proc && typeof this.proc.exitCode !== 'number') { | |||
| if (this.isAlive && this.proc && typeof this.proc.exitCode !== 'number') { | |||
There was a problem hiding this comment.
While running the tests locally found that there were some other unhandled exceptions.
Basically after the tests we kill the daemon, however some async code is still attempting to write to the daemon.
This ensures we handle that situation & thus prevent logging or unhandled errors (i.e. spurious errors being logged)
There was a problem hiding this comment.
Nice. Think that I'd seen those errors cluttering up the logs before.
| const history = await getOrCreateInteractiveWindow(ioc); | ||
|
|
||
| traceInfoIf(!!process.env.VSC_CI_ENABLE_TOO_MUCH_LOGGING, 'Got interactive window'); |
There was a problem hiding this comment.
Added some logging to find out what part is hanging when the variable tests timeout.
| @@ -59,29 +59,41 @@ async function testInnerLoop( | |||
|
|
|||
| export function runDoubleTest( | |||
| name: string, | |||
| testFunc: (type: 'native' | 'interactive') => Promise<void>, | |||
| testFunc: (this: Mocha.Context, type: 'native' | 'interactive') => Promise<void>, | |||
There was a problem hiding this comment.
Fixes to properly pass the context/scope, so we can use this.skip.
We had c.skip but that didn't work as the scope wasn't setup properly.
| super("Command 'workbench.action.closeAllEditors' timed out"); | ||
| } | ||
| } | ||
| const closeWindowsImplementation = (timeout = 15_000) => { |
There was a problem hiding this comment.
Found in the PR that VS Code was timing out here.
We've had this issue in the past hence the timeout.
Updated to ensure we retry again after sleeping for 1/2s.
Possible VSC is stuck/busy, hence giving it time & retrying.
I.e. a work around for something flaky in VS Code.
Code Coverage:
|
Code Coverage:
|
Code Coverage:
|
Code Coverage:
|
Code Coverage:
|
DonJayamanne
force-pushed
the
fixVarsTest
branch
from
651eca8 to
11aaa66
Compare
| @@ -600,6 +600,20 @@ jobs: | |||
|
|
|||
| # Used by tests for non-python kernels. | |||
| # Test are enabled via env variable `VSC_JUPYTER_CI_RUN_NON_PYTHON_NB_TEST` | |||
| - name: Install Dot.net | |||
There was a problem hiding this comment.
This seems to have been removed from main, I added it back.
| - name: Install .NET Interactive | ||
| run: dotnet tool install -g --add-source "https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json" Microsoft.dotnet-interactive | ||
| if: matrix.test-suite != 'notebookWithoutPythonExt' | ||
| - name: Install Dot.net |
There was a problem hiding this comment.
Not sure why this is here, but leave it (no harm cause).
Difficult with all of the copy paste going on in github actions - problem is with github actions.
Code Coverage:
|
For #4047