Dynamically load IPyWidget 8 scripts #12608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
force-pushed
the
issue8552Prototype
branch
from
65a4d5c to
5fa050d
Compare
DonJayamanne
commented
Jan 24, 2023
| const notebookComms = editors | ||
| .filter((editor) => this.notebookCommunications.has(editor)) | ||
| .map((editor) => this.notebookCommunications.get(editor)!); | ||
| notebookComms.forEach((comm) => comm.changeController(e.controller)); |
There was a problem hiding this comment.
Why these changes?
DonJayamanne
commented
Jan 24, 2023
| @@ -118,18 +124,15 @@ export class NotebookIPyWidgetCoordinator implements IExtensionSyncActivationSer | |||
| .forEach((editor) => { | |||
| const comms = this.notebookCommunications.get(editor); | |||
| this.notebookCommunications.delete(editor); | |||
| if (comms) { | |||
| comms.dispose(); | |||
| if (comms && comms.controller !== e.controller.controller) { | |||
There was a problem hiding this comment.
Why these changes?
DonJayamanne
commented
Jan 24, 2023
| 'ipywidgets.js' | ||
| ) | ||
| ); | ||
| // scripts.push( |
There was a problem hiding this comment.
Update build scripts to ensure dev compile and release modes have the same paths, as this is a debt item and we'd like to remove this debt now.
DonJayamanne
force-pushed
the
issue8552Prototype
branch
from
5fa050d to
b795a10
Compare
DonJayamanne
force-pushed
the
issue8552Prototype
branch
from
e41584b to
e6b6782
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8552
Related PR in widgets npm microsoft/vscode-jupyter-ipywidgets#19
TODO: