Handle failure to fetch remote kernel specs #12559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Jan 18, 2023
| * Last error thrown when listing the kernels. | ||
| * Use this property to determine if there was an error fetching kernels when there are no kernels listed. | ||
| */ | ||
| lastError?: Error; |
There was a problem hiding this comment.
I don't know the full flow here, but this pattern seems a little suspicious or like it could lead to async issues- like maybe the error should be associated with a particular call to a method or an event.
roblourens
approved these changes
Jan 18, 2023
This was referenced Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12203
Fixes #12204