Delete ctrl if associated kernel is deleted #12148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Nov 23, 2022
| @@ -302,7 +341,7 @@ export class ControllerRegistration implements IControllerRegistration { | |||
| // TODO: Don't hide controllers that are already associated with a notebook. | |||
| // If we have a notebook opened and its using a kernel. | |||
| // Else we end up killing the execution as well. | |||
| if (this.isFiltered(item.connection) && !this.isControllerAttachedToADocument(item)) { | |||
| if (this.isFiltered(item.connection) && this.canControllerBeDisposed(item)) { | |||
There was a problem hiding this comment.
This was incorrect, wonder how many users use the old filter UI, cant wait for that to be removed
too much stuff to manage due to kernel filters
DonJayamanne
force-pushed
the
deleteDeletedActiveIntepreter
branch
from
59ef208 to
737ae42
Compare
Codecov Report
@@ Coverage Diff @@
## main #12148 +/- ##
=======================================
- Coverage 70% 70% -1%
=======================================
Files 497 497
Lines 31276 31384 +108
Branches 4907 4922 +15
=======================================
+ Hits 21970 22034 +64
- Misses 7438 7470 +32
- Partials 1868 1880 +12
|
auto-merge was automatically disabled
November 23, 2022 06:20
Pull request was converted to draft
DonJayamanne
changed the title
DonJayamanne
changed the title
rebornix
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.