Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpreter picker seems to be displayed in Jupyter remote scenario #6247

Closed
DonJayamanne opened this issue Jun 10, 2021 · 10 comments
Closed
Labels
bug Issue identified by VS Code Team member as probable bug notebook-remote Applies to remote Jupyter Servers
Milestone

Comments

@DonJayamanne
Copy link
Contributor

It should not show up.

@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Jun 10, 2021
@greazer greazer added the notebook-remote Applies to remote Jupyter Servers label Aug 5, 2021
@IanMatthewHuff
Copy link
Member

Still repros.

@DonJayamanne
Copy link
Contributor Author

Could be the active interpreter that we're displaying.

@DonJayamanne
Copy link
Contributor Author

Could be caused by interactive window , as it doesn't support remote yet.

@DonJayamanne
Copy link
Contributor Author

Should be fixed

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2021
@IanMatthewHuff IanMatthewHuff added the verified Verification succeeded label Sep 29, 2021
@IanMatthewHuff
Copy link
Member

image
This is still broken. I'm debugging now. Looks like there is a bigger issue here with extension activation.

@IanMatthewHuff IanMatthewHuff removed the verified Verification succeeded label Sep 29, 2021
@IanMatthewHuff
Copy link
Member

This concerns me a bit. It looks like we are relying on onDidActivationPythonExtension, which from the code doesn't seem reliable. There are other places we are using this as well. I'm surprised that VS Code doesn't have a way to see when an extension is activated.

@microsoft microsoft unlocked this conversation Sep 30, 2021
@IanMatthewHuff
Copy link
Member

Dropping a quick note here, I see this as the probable issue here (per the comment):

this.apiProvider.onDidActivatePythonExtension(

In the remote case we are not getting this event to hook up. Which I believe could cause issues with the other usages of this.

@DonJayamanne
Copy link
Contributor Author

FYI - I added this to october as its not a ship blocker

@rchiodo
Copy link
Contributor

rchiodo commented Jan 24, 2022

I think this is working? Not sure what the problem is.

This shows in the kernel picker for interactive window (when using remote)

image

IW starts fine with remote.

@rchiodo rchiodo closed this as completed Jan 24, 2022
@rchiodo rchiodo removed their assignment Jan 24, 2022
@rchiodo
Copy link
Contributor

rchiodo commented Jan 24, 2022

@DonJayamanne do you remember what the problem was here?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-remote Applies to remote Jupyter Servers
Projects
None yet
Development

No branches or pull requests

4 participants