Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show active interpreter controller only for local #7405

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Conversation

DonJayamanne
Copy link
Contributor

For #6247

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #7405 (ec99fcb) into main (f08a71f) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##            main   #7405   +/-   ##
=====================================
- Coverage     64%     64%   -1%     
=====================================
  Files        361     361           
  Lines      22623   22623           
  Branches    3435    3435           
=====================================
- Hits       14585   14583    -2     
- Misses      6825    6828    +3     
+ Partials    1213    1212    -1     
Impacted Files Coverage Δ
.../datascience/notebook/notebookControllerManager.ts 87% <100%> (ø)
...ience/notebook/emptyNotebookCellLanguageService.ts 72% <0%> (-4%) ⬇️
...t/datascience/notebook/vscodeNotebookController.ts 78% <0%> (-3%) ⬇️
...lient/datascience/jupyter/kernels/cellExecution.ts 75% <0%> (-1%) ⬇️
...client/datascience/kernel-launcher/kernelDaemon.ts 57% <0%> (+1%) ⬆️
...ience/kernel-launcher/localKernelSpecFinderBase.ts 82% <0%> (+2%) ⬆️
...tascience/jupyter/kernels/kernelCommandListener.ts 58% <0%> (+2%) ⬆️

@DonJayamanne DonJayamanne merged commit 6616212 into main Sep 7, 2021
@DonJayamanne DonJayamanne deleted the issueFix6247 branch September 7, 2021 22:01
DonJayamanne added a commit that referenced this pull request Sep 8, 2021
* Fixes to restarting of kernels (#7400)

* Show active interpreter controller only for local (#7405)

* Refresh list of remote kernels if a notebook is already open (#7386)

* Skip variable tests (#7447)

* Changes to release

* More fixes

* Remote for IW

* Update change log

* Fixes

* oops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants