Unable to open Notebooks in Insiders #5804

sztal · 2021-05-07T15:01:59Z

Issue Type: Bug

It seems that the last update crashed Jupyter notebook extension.

It cannot find jupyter.opennotebook function/object presumably need for opening .ipynb files in the Notebook Editor. Moreover, there seems to be some even deeper problem going in the core of the extension which probably cannot load some sort of a configuration file (or so it seems according to the console log in Developer Tools. Below I paste the javascript erorr trace generated in my particular case and raised at workbench.desktop.main.js:62:

[Extension Host] extension activation failed TypeError: o.getConfiguration(...).get(...).find is not a function
    at new m (/home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:52:683169)
    at Object.t.resolveInstance (/home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:52:263270)
    at /home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:52:262475
    at Object.t.resolve (/home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:52:262738)
    at /home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:52:253835
    at e._get (/home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:52:253601)
    at e.get (/home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:52:252313)
    at a.get (/home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:90:509426)
    at /home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:52:245341
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at /home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:37:825686
    at t.activate (/home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:37:825373)
    at async Promise.all (index 0)
    at async Promise.all (index 88)
    at async Promise.all (index 1) (at /home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:37:826205)

Extension version: 2021.6.819764235
VS Code version: Code - Insiders 1.57.0-insider (6bee0f2f3fea9df1ad45344f09b2a139c93b384f, 2021-05-07T08:17:31.522Z)
OS version: Linux x64 5.11.0-7614-generic

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4710MQ CPU @ 2.50GHz (8 x 800)
GPU Status	2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: disabled_off opengl: enabled_on rasterization: disabled_software skia_renderer: enabled_on video_decode: disabled_software vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	0, 0, 1
Memory (System)	15.52GB (6.13GB free)
Process Argv	--unity-launch --crash-reporter-id ea2cc0b8-cf43-49b3-a0ce-43755c989cd5
Screen Reader	no
VM	0%
DESKTOP_SESSION	ubuntu
XDG_CURRENT_DESKTOP	Unity
XDG_SESSION_DESKTOP	ubuntu
XDG_SESSION_TYPE	x11

The text was updated successfully, but these errors were encountered:

DonJayamanne · 2021-05-07T15:14:55Z

Thanks for filling this issue, I'll look into this asap.

DonJayamanne · 2021-05-07T16:25:48Z

Hmm, looks like theres a bug in VS Code microsoft/vscode#123307

DonJayamanne · 2021-05-07T16:26:46Z

Yup, i too can replicate this.

joyceerhl · 2021-05-07T20:09:53Z

This should be fixed in the latest VS Code Insiders build:

Version: 1.57.0-insider (user setup)
Commit: a19565da7dfc739fa26e36aae96113e19fe3806f
Date: 2021-05-07T17:19:03.737Z

@sztal could you please update VS Code Insiders and let us know if the issue persists? Thanks and sorry for the trouble!

sztal · 2021-05-07T20:18:50Z

Hi, many thanks for such a quick reaction! However, it seems the problem still persists.

I updated VS Code correctly, I think (below is the version info I get after updating):

code-insiders --version
# OUTPUT
# 1.57.0-insider
# a19565da7dfc739fa26e36aae96113e19fe3806f
# x64

The errors I see in Developer Tools seems to be identical. And crucially, when I inspect settings I still see that:

"workbench.editorAssociations": [
        {
            "viewType": "jupyter.notebook.ipynb",
            "filenamePattern": "*.ipynb"
        }
    ],

is marked with a warning Incorrect type. Expected "object" and from what I could understand from the above discussions in the issue tickets the problem was related to some incompatibilities in how this config item is represented, right? So unfortunately it seems the problem is not solved yet.

Hanuphant · 2021-05-07T20:44:16Z

The same issue is affecting me too.

joyceerhl · 2021-05-07T20:44:56Z

@sztal To be clear, you cannot open notebooks even after upgrading?

The warning is benign. TLDR VS Code has changed the layout for this setting, but internally they are supposed to still recognize the old format (though we are likely going to upgrade to the new layout, see #5806). There was a bug that caused their backward compatibility code to fail which we're told has since been fixed. But if you can't open notebooks at all then the problem is somewhere else.

joyceerhl · 2021-05-07T20:45:26Z

@Hanuphant, are you on the latest VS Code Insiders? There was an update that shipped 3 hours ago which should have resolved this.

Hanuphant · 2021-05-07T20:47:10Z

@Hanuphant, are you on the latest VS Code Insiders? There was an update that shipped 3 hours ago which should have resolved this.

Yes, it is still not working. Updated 10 mins ago.

sztal · 2021-05-07T20:49:02Z

@joyceerhl , yes, I still cannot open any notebook. In some cases they are opened as plain text .json files and in some cases VS Code just hangs while trying to open them. And also, all the errors I mentioned earlier are still there in the DevTools Console. In particular, there is this one which looks probably most worrying (raised at workbench.desktop.main.js:62):

extension activation failed TypeError: o.getConfiguration(...).get(...).find is not a function
    at new m (/home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:52:683169)
    at Object.t.resolveInstance (/home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:52:263270)
    at /home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:52:262475
    at Object.t.resolve (/home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:52:262738)
    at /home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:52:253835
    at e._get (/home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:52:253601)
    at e.get (/home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:52:252313)
    at a.get (/home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:90:509426)
    at /home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:52:245341
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at /home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:37:825686
    at t.activate (/home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:37:825373)
    at async Promise.all (index 0)
    at async Promise.all (index 88)
    at async Promise.all (index 1) (at /home/sztal/.vscode-insiders/extensions/ms-toolsai.jupyter-2021.6.819764235/out/client/extension.js:37:826205)
S @ workbench.desktop.main.js:sourcemap:62

Hanuphant · 2021-05-07T20:52:45Z

Currently, from the dev view there are 4 errors and 3 warnings shown now. The update did fix a 5th one which appeared earlier in the day.

workbench.desktop.main.js:1799 Unable to instantiate workbench contribution f. TypeError: Cannot read property 'windowsExec' of undefined at f._refreshOpenInTerminalMenuItemTitle (workbench.desktop.main.js:1973) at new f (workbench.desktop.main.js:1973) at g._createInstance (workbench.desktop.main.js:625) at g.createInstance (workbench.desktop.main.js:625) at S.safeCreateInstance (workbench.desktop.main.js:1799) at S.doInstantiateByPhase (workbench.desktop.main.js:1799) at workbench.desktop.main.js:1799

	safeCreateInstance	@	workbench.desktop.main.js:1799

(node:17900) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use Code - Insiders --trace-deprecation ... to show where the warning was created) (at writeOut (internal/process/warning.js:43:3))

Extension activation failed, run the 'Developer: Toggle Developer Tools' command for more information.

workbench.desktop.main.js:62 [Extension Host] extension activation failed TypeError: o.getConfiguration(...).get(...).find is not a function
at new m (c:\Users\shreyash.vscode-insiders\extensions\ms-toolsai.jupyter-2021.6.819764235\out\client\extension.js:52:683169)
at Object.t.resolveInstance (c:\Users\shreyash.vscode-insiders\extensions\ms-toolsai.jupyter-2021.6.819764235\out\client\extension.js:52:263270)
at c:\Users\shreyash.vscode-insiders\extensions\ms-toolsai.jupyter-2021.6.819764235\out\client\extension.js:52:262475
at Object.t.resolve (c:\Users\shreyash.vscode-insiders\extensions\ms-toolsai.jupyter-2021.6.819764235\out\client\extension.js:52:262738)
at c:\Users\shreyash.vscode-insiders\extensions\ms-toolsai.jupyter-2021.6.819764235\out\client\extension.js:52:253835
at e._get (c:\Users\shreyash.vscode-insiders\extensions\ms-toolsai.jupyter-2021.6.819764235\out\client\extension.js:52:253601)
at e.get (c:\Users\shreyash.vscode-insiders\extensions\ms-toolsai.jupyter-2021.6.819764235\out\client\extension.js:52:252313)
at a.get (c:\Users\shreyash.vscode-insiders\extensions\ms-toolsai.jupyter-2021.6.819764235\out\client\extension.js:90:509426)
at c:\Users\shreyash.vscode-insiders\extensions\ms-toolsai.jupyter-2021.6.819764235\out\client\extension.js:52:245341
at processTicksAndRejections (internal/process/task_queues.js:93:5)
at async c:\Users\shreyash.vscode-insiders\extensions\ms-toolsai.jupyter-2021.6.819764235\out\client\extension.js:37:825686
at async t.activate (c:\Users\shreyash.vscode-insiders\extensions\ms-toolsai.jupyter-2021.6.819764235\out\client\extension.js:37:825373)
at async Promise.all (index 0)
at async Promise.all (index 89)
at async Promise.all (index 1) (at c:\Users\shreyash.vscode-insiders\extensions\ms-toolsai.jupyter-2021.6.819764235\out\client\extension.js:37:826205)

The aforementioned are the errors I am seeing now.

joyceerhl · 2021-05-07T20:58:36Z

Yep I repro the bug. Assigning to myself for investigation. Thanks for letting us know.

joyceerhl · 2021-05-07T21:13:38Z

@DonJayamanne It's working for you because your settings.json still contains the old editorAssociations setting format. If you delete it, this code here falls over and crashes activation:

vscode-jupyter/src/client/common/experiments/service.ts

Lines 64 to 70 in 94ff177

    
           // Custom settings just for native notebook support. 
        
           const settings = workspaceService.getConfiguration('workbench', undefined); 
        
           const editorAssociations = settings.get('editorAssociations') as { 
        
               viewType: string; 
        
               filenamePattern: string; 
        
           }[]; 
        
           if (editorAssociations.find((a) => a.viewType && a.viewType.includes('jupyter-notebook'))) {

joyceerhl · 2021-05-07T21:32:03Z

As a temporary workaround @sztal and @Hanuphant, you can replace the workbench.editorAssociations setting with the following:

    "workbench.editorAssociations": [
        {
            "viewType": "jupyter-notebook",
            "filenamePattern": "*.ipynb"
        }
    ]

I assume both of you have intentionally opted out of the native notebooks UI. However this will allow the Jupyter extension to activate. We're working on a fix for this (basically we need to support reading the new setting format that VS Code has introduced, which is the default layout now).

sztal · 2021-05-07T21:36:55Z

Thanks! But now I am a bit confused. I did not want to opt out from the native notebooks UI. As a matter of fact it was the reason I started to use VS Code Insiders in the first place. So does it mean that I could have opted out somehow accidentally? And if so, how can I check this?

joyceerhl · 2021-05-07T21:39:13Z

Do you have "jupyter.experiments.optOutFrom": [ "NativeNotebookEditor" ] or "jupyter.experiments.enabled": false set anywhere in your settings.json?

The "jupyter.notebook.ipynb" viewType is for our custom editor implementation of notebooks. So you shouldn't have that entry there. The "jupyter-notebook" viewType is for our native notebooks implementation.

sztal · 2021-05-07T21:41:38Z

But in the meantime, I confirm that your solution works (and I still have new native notebooks).

I think that this jupyter.notebook.ipynb was somehow added during upgrading of VS Code, but I am not sure. However I really do believe that it was just jupyter-notebook earlier. Nonetheless, now I corrected the settings and everything seem to be fine.

So once again, thanks a lot for solving it so quickly!

Hanuphant · 2021-05-07T21:54:38Z

Do you have "jupyter.experiments.optOutFrom": [ "NativeNotebookEditor" ] or "jupyter.experiments.enabled": false set anywhere in your settings.json?

The "jupyter.notebook.ipynb" viewType is for our custom editor implementation of notebooks. So you shouldn't have that entry there. The "jupyter-notebook" viewType is for our native notebooks implementation.

Yeah, I did have "jupyter.experiments.optOutFrom": ["NativeNotebookEditor"] in my settings.json.

I am quite new to this, will you be able to help me out with workbench.editorAssociation . Do I have to add that code in settings.json?

joyceerhl · 2021-05-07T22:01:03Z

Yup, you would delete the existing "workbench.editorAssociations" key and value, and replace it with this snippet:

    "workbench.editorAssociations": [
        {
            "viewType": "jupyter-notebook",
            "filenamePattern": "*.ipynb"
        }
    ]

Hanuphant · 2021-05-07T22:14:32Z

Yup, you would delete the existing "workbench.editorAssociations" key and value, and replace it with this snippet:
    "workbench.editorAssociations": [
        {
            "viewType": "jupyter-notebook",
            "filenamePattern": "*.ipynb"
        }
    ]

Thanks a lot @joyceerhl & devs. It worked!!!

flipphillips · 2021-05-07T23:26:32Z

I too was using Insider for the native view capability.

joyceerhl · 2021-05-07T23:30:44Z

@flipphillips are you also unable to open notebooks in insiders? Does this workaround help?: #5804 (comment)

flipphillips · 2021-05-07T23:33:35Z

@joyceerhl - I see what the problem is/was, that the settings format is different now than what was in the synced settings (I had other associations in there too).

It appears that this manual fix worked, thanks!

It does complain that the setting is wrong, btw -

joyceerhl · 2021-05-08T00:08:27Z

Yeah the new VS Code core setting IntelliSense flags the old format as an error, but it's still supported for backward compatibility. We (Jupyter extension) are working on a fix to migrate workbench.editorAssociations to the new format.

flipphillips · 2021-05-08T00:27:37Z

Groovy - makes sense. I'll do the best to pass on the secret sauce to my students. Ironically, I was just showing them the cool/better notebook interface in class, then they got home and couldn't get it to work because of this :) Such is living on the edge.

joyceerhl · 2021-05-08T03:53:40Z

@flipphillips Yeah, sorry about the snafu. Team is out for the week but we should have this fixed Monday.

joyceerhl · 2021-05-10T19:45:50Z

This should be fixed in the latest Jupyter extension build targeting VS Code Insiders: v2021.6.828932339.

joyceerhl · 2021-05-11T00:36:10Z

Closing as this should have been resolved with today's update. Please feel free to open a new issue if otherwise. Thanks everyone for your patience and for reporting a bug!

github-actions bot assigned claudiaregio May 7, 2021

DonJayamanne changed the title ~~jupyter.opennotebook not found~~ Unable to open Notebooks in Insiders May 7, 2021

roblourens mentioned this issue May 7, 2021

Unable to configure edito associations in settings.json workbench.editorAssociations used to be an array microsoft/vscode#123307

Closed

DonJayamanne mentioned this issue May 7, 2021

Unable to open existing and new Jupyter Notebooks #5794

Closed

joyceerhl assigned joyceerhl and unassigned claudiaregio May 7, 2021

joyceerhl pinned this issue May 7, 2021

joyceerhl mentioned this issue May 7, 2021

Fails to open with latest insiders build #5808

Closed

joyceerhl mentioned this issue May 7, 2021

Support new workbench.editorAssociations setting format #5810

Merged

19 tasks

joyceerhl mentioned this issue May 8, 2021

Jupyter Extension activation failed. #5815

Closed

This was referenced May 9, 2021

Extension activation failed on VS Code Insiders: ERR Cannot have two contributions with the same id editor.contrib.acceptChangesButton #5817

Closed

Update Display Data disappears when display and display.update are in the same cell #1710

Closed

joyceerhl closed this as completed May 11, 2021

joyceerhl unpinned this issue May 11, 2021

github-actions bot locked as resolved and limited conversation to collaborators May 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unable to open Notebooks in Insiders #5804

Unable to open Notebooks in Insiders #5804

sztal commented May 7, 2021

DonJayamanne commented May 7, 2021

DonJayamanne commented May 7, 2021

DonJayamanne commented May 7, 2021

joyceerhl commented May 7, 2021

sztal commented May 7, 2021

Hanuphant commented May 7, 2021

joyceerhl commented May 7, 2021

joyceerhl commented May 7, 2021

Hanuphant commented May 7, 2021

sztal commented May 7, 2021

Hanuphant commented May 7, 2021

joyceerhl commented May 7, 2021

joyceerhl commented May 7, 2021

joyceerhl commented May 7, 2021

sztal commented May 7, 2021

joyceerhl commented May 7, 2021

sztal commented May 7, 2021

Hanuphant commented May 7, 2021

joyceerhl commented May 7, 2021

Hanuphant commented May 7, 2021

flipphillips commented May 7, 2021

joyceerhl commented May 7, 2021

flipphillips commented May 7, 2021 •

edited

Loading

joyceerhl commented May 8, 2021

flipphillips commented May 8, 2021

joyceerhl commented May 8, 2021

joyceerhl commented May 10, 2021

joyceerhl commented May 11, 2021

Unable to open Notebooks in Insiders #5804

Unable to open Notebooks in Insiders #5804

Comments

sztal commented May 7, 2021

DonJayamanne commented May 7, 2021

DonJayamanne commented May 7, 2021

DonJayamanne commented May 7, 2021

joyceerhl commented May 7, 2021

sztal commented May 7, 2021

Hanuphant commented May 7, 2021

joyceerhl commented May 7, 2021

joyceerhl commented May 7, 2021

Hanuphant commented May 7, 2021

sztal commented May 7, 2021

Hanuphant commented May 7, 2021

joyceerhl commented May 7, 2021

joyceerhl commented May 7, 2021

joyceerhl commented May 7, 2021

sztal commented May 7, 2021

joyceerhl commented May 7, 2021

sztal commented May 7, 2021

Hanuphant commented May 7, 2021

joyceerhl commented May 7, 2021

Hanuphant commented May 7, 2021

flipphillips commented May 7, 2021

joyceerhl commented May 7, 2021

flipphillips commented May 7, 2021 • edited Loading

joyceerhl commented May 8, 2021

flipphillips commented May 8, 2021

joyceerhl commented May 8, 2021

joyceerhl commented May 10, 2021

joyceerhl commented May 11, 2021

flipphillips commented May 7, 2021 •

edited

Loading