Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No direct cell output when CDN disabled #12893

Closed
rzhao271 opened this issue Feb 21, 2023 · 7 comments
Closed

No direct cell output when CDN disabled #12893

rzhao271 opened this issue Feb 21, 2023 · 7 comments
Assignees
Labels
debt Code quality issues ipywidgets Rendering, loading, saving, anything to do with IPyWidgets

Comments

@rzhao271
Copy link
Contributor

Testing #12874

On insiders.vscode.dev on Microsoft Edge
Jupyter extension version: v2023.2.1000531229
Python extension version: v2023.3.10481011
Using ipywidgets 7

  1. Create a new notebook
  2. Add the following cell
# Sample1
from ipyleaflet import Map, Marker

center = (52.204793, 360.121558)

m = Map(center=center, zoom=15)

marker = Marker(location=center, draggable=True)
m.add_layer(marker);

display(m)
  1. Configure "jupyter.widgetScriptSources": [] in user settings. Reload.
  2. Run the cell.
  3. 🐛 The output is blank. The status is a checkmark, but several seconds later, an error dialog pops up saying that I need to allow access to CDNs. I was expecting the status to be an X with a status message saying that a result couldn't be produced because access to CDNs wasn't allowed.
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug ipywidgets Rendering, loading, saving, anything to do with IPyWidgets labels Feb 22, 2023
@DonJayamanne DonJayamanne added this to the February 2023 milestone Feb 22, 2023
@DonJayamanne
Copy link
Contributor

This should be fixed in the latest pre-release version of the Jupyter extension

@DonJayamanne DonJayamanne added the author-verification-requested Issues potentially verifiable by issue author label Feb 22, 2023
@rzhao271
Copy link
Contributor Author

rzhao271 commented Feb 22, 2023

Doesn't seem to be working with Jupyter extension version v2023.2.1000541047 and ipywidgets 7.7.2 in a virtualenv.

The result is still blank, and there's a checkmark.
Screenshot showing cell and checkmark

@rzhao271 rzhao271 reopened this Feb 22, 2023
@rzhao271 rzhao271 added verification-found Issue verification failed and removed author-verification-requested Issues potentially verifiable by issue author labels Feb 22, 2023
@DonJayamanne
Copy link
Contributor

Please could you enable logging as follows:

  • Open settings & go into Jupyter->Logging
  • Change the value to verbose
  • Reload VS Code,
  • Attempt to repro the issue & then copy the output from the Jupyter output panel.
    Also, please could you check if there are any errors in the console window in Developer Tools

@DonJayamanne DonJayamanne added the info-needed Issue requires more information from poster label Feb 23, 2023
@rzhao271
Copy link
Contributor Author

rzhao271 commented Feb 24, 2023

I can still repro #12893 (comment) on the latest Jupyter and Python pre-release extensions.

There's a few errors in the console window in devtools:

extension.web.bundle.js:11 
        
       Uncaught (in promise) Error: Python Extension API not exported
    at R.registerHooks (extension.web.bundle.js:11:336057)
    at R.init (extension.web.bundle.js:11:335409)
    at R.getNewApi (extension.web.bundle.js:11:335178)
    at M.getApi (extension.web.bundle.js:11:345442)
    at M.hookupOnDidChangeInterpreterEvent (extension.web.bundle.js:11:348376)
    at M.getInterpreters (extension.web.bundle.js:11:340971)
    at M.populateCachedListOfInterpreters (extension.web.bundle.js:11:345696)
    at M.buildListOfInterpretersForFirstTime (extension.web.bundle.js:11:347750)
    at M.hookupOnDidChangeInterpreterEvent (extension.web.bundle.js:11:348333)
    at M.get onDidChangeInterpreter [as onDidChangeInterpreter] (extension.web.bundle.js:11:340501)

There's also the following error, though I purposely have CDN disabled:

Error: Module jupyter-leaflet, semver range ^0.17 is not registered as a widget module

Logs:
jupyter-output-view-output.txt
devtools-log.log

@DonJayamanne DonJayamanne modified the milestones: March 2023, April 2023 Mar 21, 2023
@DonJayamanne DonJayamanne modified the milestones: April 2023, May 2023 Apr 26, 2023
@DonJayamanne DonJayamanne removed the verification-found Issue verification failed label Apr 27, 2023
@DonJayamanne DonJayamanne removed this from the May 2023 milestone Apr 28, 2023
@DonJayamanne DonJayamanne added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster labels Jul 18, 2023
@DonJayamanne
Copy link
Contributor

Closing as not planned, not worth this as its only when users change between multiple options.
So far we have never run into this.

@DonJayamanne
Copy link
Contributor

Going to re-open as this is will need to be fixed, else its just a pain when testing

@DonJayamanne DonJayamanne reopened this Nov 22, 2023
@DonJayamanne
Copy link
Contributor

Not worth the effort.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues ipywidgets Rendering, loading, saving, anything to do with IPyWidgets
Projects
None yet
Development

No branches or pull requests

3 participants