Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better indicate lack of variables in async call stacks #353

Closed
dbaeumer opened this issue Feb 26, 2020 · 5 comments
Closed

Better indicate lack of variables in async call stacks #353

dbaeumer opened this issue Feb 26, 2020 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality upstream verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@dbaeumer
Copy link
Member

microsoft/vscode#91326

When clicking through the call stack I noticed that for quite some frame no variables are shown. It is unclear to me whether this is a bug (I do think so since there are always variables in the frame) or whether the variables are not available anymore (in which case the debugger should tell me)

capture

@connor4312
Copy link
Member

It looks like you're in an async call stack--unfortunately Chrome only provides us variables for the current (synchronous) call stack. I will look into whether we can add any text to the variables view to indicate that state.

@connor4312 connor4312 added this to the March 2020 milestone Feb 26, 2020
@connor4312 connor4312 added the feature-request Request for new features or functionality label Feb 26, 2020
@connor4312 connor4312 changed the title Empty variables view Better indicate lack of variables in async call stacks Feb 26, 2020
@connor4312
Copy link
Member

Right now we don't have a good way to display errors/text in this case, see the linked issue. Once resolved I have a change ready to go that will show an appropriate message there.

@connor4312
Copy link
Member

Added the error in js-debug, pending changes in vscode for it to actually be surfaced.

@connor4312 connor4312 added the verification-needed Verification of issue is requested label Mar 30, 2020
@rebornix rebornix added the verification-steps-needed Steps to verify are needed for verification label Apr 2, 2020
@rebornix
Copy link
Member

rebornix commented Apr 2, 2020

@connor4312 what's the right js app to verify this issue? Or I can test this in any js app?

@connor4312
Copy link
Member

Jackson verified this in microsoft/vscode#92102 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality upstream verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants