Selection Range support. Part of Microsoft/vscode#65925 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeschli
reviewed
Jan 24, 2019
|
|
||
| suite('HTML SelectionRange', () => { | ||
| test('Basic', () => { | ||
| assertRanges('<div|>foo</div>', [[1, 4], [0, 14]]); |
There was a problem hiding this comment.
shouldn't [1,4] be [1,3]?
For readability, maybe format the expected ranges like [ "1:div", "0:<div>foo</div>"]
| content = content.substr(0, offset) + content.substr(offset + 1); | ||
|
|
||
| const document = TextDocument.create('test://foo/bar.html', 'html', 1, content); | ||
| const actualRanges = getApplicableRanges(document, document.positionAt(offset)); |
There was a problem hiding this comment.
Ideally write the tests against the public API (htmlLanguageService.getSelectionRanges), that way we are sure it works end-to-end and the implementation can be changed freely without impacting any tests.
| assertRanges('<div>foo</|div>', [[10, 13], [0, 14]]); | ||
| assertRanges('<div>foo</di|v>', [[10, 13], [0, 14]]); | ||
| assertRanges('<div>foo</div|>', [[10, 13], [0, 14]]); | ||
| }); |
There was a problem hiding this comment.
also test self closed tags (<div foo="sdsdd"/>)
| test('Multiple Attribute Value', () => { | ||
| assertRanges('<div class="foo" id="|bar">foo</div>', [[21, 24], [20, 25], [17, 25], [1, 25], [0, 35]]); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
test comments and doctypes as well
|
Nice work! |
|
@aeschli Thanks! Addressed all your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.