This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
More alignment with the latest vscode extension dev setup #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…son so that the vscode setup can control the .d.ts files that are used.
lukehoban
added a commit
that referenced
this pull request
Oct 21, 2015
More alignment with the latest vscode extension dev setup
|
Great - thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the development setup, we now define noLib=false in the tsconfig.json, so that the vscode module can provide the typings that match the code/electron versions/node versions. This pull request deletes the 'custom' installed typings for node, es6 collections.
We also had an issue with exposing the Thenable interface from the vscode module. We have fixed this but you need to run npm update to get this fix.