Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update glob usage in testing extension #7125

Merged
merged 1 commit into from
Mar 22, 2024
Merged

docs: update glob usage in testing extension #7125

merged 1 commit into from
Mar 22, 2024

Conversation

yoshinorin
Copy link
Contributor

The glob library used in the testing example docs has been updated to use promise instead of callback starting from version v9.0.0. This PR will update the documentation for these changes.

https://github.com/isaacs/node-glob/blob/v9/changelog.md#90

Thanks :)

@yoshinorin yoshinorin mentioned this pull request Mar 20, 2024
Merged
@ntrogh ntrogh self-requested a review March 22, 2024 12:15
ntrogh
ntrogh approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@ntrogh ntrogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoshinorin thanks for updating this in our docs.

@ntrogh ntrogh merged commit 4eb48b1 into microsoft:main Mar 22, 2024
1 of 2 checks passed
@yoshinorin yoshinorin deleted the docs/update-glob-usage-in-testing-ext branch March 22, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntrogh ntrogh ntrogh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoshinorin @ntrogh