Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FastAPI tutorial to Python docs #6760

Merged
merged 28 commits into from
Oct 26, 2023
Merged

Add FastAPI tutorial to Python docs #6760

merged 28 commits into from
Oct 26, 2023

Conversation

luabud
Copy link
Member

@luabud luabud commented Oct 24, 2023

luabud and others added 21 commits October 13, 2023 20:20
@luabud
Add initial draft of FastAPI tutorial
99edc2c
@luabud
Fix item query bug
36c07a6
@luabud @cwebster-99
Apply suggestions from code review
99f6791 
Co-authored-by: Courtney Webster <[email protected]>
@luabud
Fix typo
2f398c7
@luabud
Change code sample to use delete
2d927eb
@luabud
Fix headers
5c0f72d
@luabud
Fix sample image
e76ab58
@luabud
Fix dictionary sample
2825091
@luabud @debonte
Apply suggestions from code review
c1a8898 
Co-authored-by: Erik De Bonte <[email protected]>
@luabud @debonte
Apply suggestions from code review
25d78e7 
Co-authored-by: Erik De Bonte <[email protected]>
@luabud
Address code review comments
9c31741
@luabud
Add link to docs and remove other extensions
23eea04
@luabud
Tweak wording
f328e00
@luabud
Fix screenshots and inputs for add_item
f1160b5
@luabud
Fix dict based sample
1683858
@luabud
Make multiple fixes
43d05e4
@luabud
Add beginners disclaimer
011185f
@luabud
Address PR comments
f35e2ea
@luabud
Add more context around redis
ecf6bc6
@luabud @debonte
Update docs/python/tutorial-fastapi.md
cf542d6 
Co-authored-by: Erik De Bonte <[email protected]>
@luabud
Fix typos
6273480
This was referenced Oct 24, 2023
Closed
Closed
Closed
Closed
@luabud luabud marked this pull request as ready for review October 25, 2023 02:41
cwebster-99
cwebster-99 previously approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@cwebster-99 cwebster-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great with all of the feedback incorporated! Awesome work!

Tyriar
Tyriar reviewed Oct 25, 2023
View reviewed changes
bamurtaugh
bamurtaugh reviewed Oct 25, 2023
View reviewed changes
Copy link
Member

@bamurtaugh bamurtaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for mentioning dev containers, love this cross-linking! I think the steps are great, mostly commented on some formatting or cross-linking suggestions.

@luabud @Tyriar @cwebster-99
Apply suggestions from code review
e97c885 
Co-authored-by: Daniel Imms <[email protected]>
Co-authored-by: Courtney Webster <[email protected]>
@luabud luabud added the python label Oct 26, 2023
@luabud luabud requested a review from gregvanl October 26, 2023 18:15
@gregvanl gregvanl merged commit c859b90 into microsoft:main Oct 26, 2023
@gregvanl
Copy link

Thanks!

@luabud luabud mentioned this pull request Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isidorn isidorn isidorn left review comments

@Tyriar Tyriar Tyriar left review comments

@lszomoru lszomoru lszomoru left review comments

@bamurtaugh bamurtaugh bamurtaugh left review comments

@gregvanl gregvanl gregvanl approved these changes

@cwebster-99 cwebster-99 cwebster-99 left review comments

@minsa110 minsa110 Awaiting requested review from minsa110

Assignees

@luabud luabud

Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@luabud @gregvanl @isidorn @Tyriar @lszomoru @bamurtaugh @cwebster-99