Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a git bash section to shell integration #5559

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Add a git bash section to shell integration #5559

merged 2 commits into from
Aug 9, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 9, 2022

Part of microsoft/vscode#143769, this is new coming in 1.71

@IllusionMH
Copy link
Contributor

and a minor change will improve it further.

So is it already makes sense to report issues related to Git Bash or it's better to wait for future change that should improve situation as it's mentioned in comment?

@Tyriar
Copy link
Member Author

Tyriar commented Aug 9, 2022

@IllusionMH let's try consolidate issues in #143769 for now to reduce noise as I suspect a lot of git bash problems will also apply to Windows pwsh, we can always fork them into a new issue if needed. For example there will be a few problems with the decorations jumping around, those have the same root cause as microsoft/vscode#153476; conpty may put the sequences in the wrong spot and we try fix up the position after the command has run.

@Tyriar
Copy link
Member Author

Tyriar commented Aug 9, 2022

microsoft/vscode#157697 was the minor change btw 🙂

@Tyriar Tyriar merged commit 36e2f12 into vnext Aug 9, 2022
@Tyriar Tyriar deleted the tyriar/git-bash branch August 9, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants