feat: add image property for better organization #4426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…better organization
|
@microsoft-github-policy-service agree |
bwateratmsft
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Code looks good to me. @fiveisprime any objections to this from PM perspective?
OGCJM11
approved these changes
Dec 5, 2024
|
No objection from me, looks good. |
|
Thanks for the contribution @yoyoys! |
|
@bwateratmsft Would you add this to milestones? :) |
|
Done! Not sure when it will be shipping though, given the holidays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using Google Cloud and the repository path is so mess up and useless like this:
And I've add
RegistryAndPathandRepositoryNameShortand to filter them like this:The code is tested and pass all the built-in testes,
and no effect to current users until they use new image property,
hope this is helpful for everyone. Thanks