This repository has been archived by the owner on Nov 30, 2023. It is now read-only.
Remove "lts" / "latest" definitions in favor of version, add eslint to TS definitions #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense. 👍 |
chrmarti
approved these changes
Nov 7, 2019
…scode-dev-containers into clantz/node-refactor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been a few cases where an update to a "latest" or "lts" tag has broken a definition. Instead of using these tags, we can keep dev containers for current versions of runtimes and deprecate those that are no longer in support.
This change will also be required to implement #140 and also addresses #141 for .NET Core
We will need to adjust comments that are added to devcontainer.json files to that points to the README in the release tag tree instead of master so that people can still get to READMEs for deprecated containers.
This update also adds eslint to the TypeScript definitions now that tslint has been deprecated.